Thanks to visit codestin.com
Credit goes to github.com

Skip to content

upgrade: add Longhorn CRD migrations during upgrade #9284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade: add Longhorn CRD migrations during upgrade #9284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions package/upgrade/upgrade_manifests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,43 @@ apply_extra_nonversion_manifests()
shopt -u nullglob
}

migrate_longhorn_v1beta1_crds() {

# reference: https://longhorn.io/docs/1.10.0/important-notes/#upgrade
# Harvester v1.6.x -> v1.7.x, Longhorn is upgraded from v1.9.x to v1.10.x
echo "Checking if migrating Longhorn v1beta1 CRDs to v1beta2 is required, it only occurs from v1.6.x to v1.7.x upgrade"
if [[ ! "$UPGRADE_PREVIOUS_VERSION" =~ ^v1\.6\.[0-9]$ ]]; then
echo "Skip migrate longhorn v1beta1 CRDs with Harvester version $UPGRADE_PREVIOUS_VERSION"
return
fi

# Temporarily disable the Longhorn webhook for CR validation
echo "Temporarily disabling the Longhorn webhook validator..."
kubectl patch validatingwebhookconfiguration longhorn-webhook-validator \
--type=merge \
-p "$(kubectl get validatingwebhookconfiguration longhorn-webhook-validator -o json | jq '.webhooks[0].rules |= map(if .apiGroups == ["longhorn.io"] and .resources == ["settings"] then .operations |= map(select(. != "UPDATE")) else . end)')"

# Find and migrate CRDs with v1beta1 stored versions
echo "Starting migration of CRDs that store v1beta1 resources to v1beta2"
migration_time="$(date +%Y-%m-%dT%H:%M:%S)"
crds=($(kubectl get crd -l app.kubernetes.io/name=longhorn -o json | jq -r '.items[] | select(.status.storedVersions | index("v1beta1")) | .metadata.name'))
for crd in "${crds[@]}"; do
echo "Migrating ${crd} ..."
for name in $(kubectl -n longhorn-system get "$crd" -o jsonpath='{.items[*].metadata.name}'); do
echo "migrating ${name} ..."
kubectl patch "${crd}" "${name}" -n longhorn-system --type=merge -p='{"metadata":{"annotations":{"migration-time":"'"${migration_time}"'"}}}'
done

kubectl patch crd "${crd}" --type=merge -p '{"status":{"storedVersions":["v1beta2"]}}' --subresource=status
done

# Re-enable the Longhorn webhook
echo "Re-enabling the CR validation webhook..."
kubectl patch validatingwebhookconfiguration longhorn-webhook-validator \
--type=merge \
-p "$(kubectl get validatingwebhookconfiguration longhorn-webhook-validator -o json | jq '.webhooks[0].rules |= map(if .apiGroups == ["longhorn.io"] and .resources == ["settings"] then .operations |= (. + ["UPDATE"] | unique) else . end)')"
}

wait_repo
detect_repo
detect_upgrade
Expand All @@ -1253,6 +1290,7 @@ skip_restart_rancher_system_agent
upgrade_rancher
patch_local_cluster_details
update_local_rke_state_secret
migrate_longhorn_v1beta1_crds
upgrade_harvester_cluster_repo
ensure_ingress_class_name
apply_extra_nonversion_manifests
Expand Down