Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dlech
Copy link
Collaborator

@dlech dlech commented May 18, 2025

Mostly typing improvements. Removing some dead code.

And one user-facing change to make BLEDevice.name be more consistent on all platforms.

dlech added 12 commits May 18, 2025 11:00
This is used in multiple files, so shouldn't be considered "private"
Inheritance of __init__ doesn't follow normal rules, so the type checker
isn't liking it.
Drop the method from the abstract base class and make it private in the
backend implementations.
Make it clear which methods are overriding the base class.
This was not implemented on most backends.

BlueZ handles it during the start scan method.
Indicate overridden methods from base class.
Other backends don't have this, so android shouldn't either.
BlueZ will use the address of a Bluetooth device as the name if it
doesn't have a name. All other platforms will use None. So to be
consistent, make the BlueZ backend use None as well.
@dlech dlech merged commit 9c11c6e into hbldh:develop May 18, 2025
16 checks passed
@dlech dlech deleted the more-typing branch May 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant