Winrt pair args #1770
Merged
Winrt pair args #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to deprecate this, so it shouldn't be part of the public API. It still works thanks to kwargs.
Apparently, can_pair is False if a device is already paired, so we need to reverse the order of the checks in order to avoid raising an exception when trying to pair a device that is already paired.
Recent versions of Python only print the int value of IntEnum. Printing the name is more user-friendly.
Seems to be a bug in the WinRT API where the value returned by the pairing status result is not updated unless we request a device info update first.
This should remove the need for the protection_level kwarg. Not sure if the retry is actually needed since on the device used for testing, it connects at the ENCRYPTION level on the first try.
Now that the default behavior is to try to use the highest protection level, there should no longer be a need to manually set the protection level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks pairing on WinRT backend so that hopefully we no longer need the platform-specific
protection_levelargument.Instead, the highest possible level is tried by default.
Also fixes a few minor bugs noticed while testing.