bluez/client: move state management to global BlueZ manager #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a number of bugs by moving the `BleakClient` state management to the new global BlueZ manager object. - Calling "GetManagedObjects" each time we connected caused performance issues. Fixes #500. - Calling "ConnectDevice" didn't work as expected and has been removed/ Fixes #806. - BleakClient didn't handle "InterfacesRemoved" which resulted in an invalid service dictionary in some cases. Fixes #882.
This was referenced Jul 26, 2022
This works around a bug in the dbus_next library where the socket is not closed on disconnect. Fixes #805.
|
I also added an addition commit that fixes leaking file descriptors since we couldn't remove the separate D-Bus socket completely. Fixes #805. |
bdraco
approved these changes
Jul 26, 2022
23 tasks
|
Thanks for this patch. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of bugs by moving the
BleakClientstate management to the new global BlueZ manager object.