Fix div being closed by raw block content#87
Merged
hellux merged 1 commit intohellux:masterfrom Feb 19, 2025
Merged
Conversation
Currently a div gets closed if it contains a raw block that in turn contains what could be the div's closing fence. This commit fixes that by keeping track of open code blocks when looking for the closing fence. It also removes the existing test for this case from the `skip` file. fixes hellux#6
Contributor
Author
|
Hey again 😉 I figured now that I had poked some of the code anyways, #6 might be some low-hanging fruit. I am however not completely satisfied with the result. I feel like the readability is not great, but I haven't really had a good idea yet on how to improve it. I considered various ways to break up existing match arms, but they'd all just end up doing pretty similar stuff. Maybe you have a better idea? |
Owner
|
This looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a div gets closed if it contains a raw block that in turn contains what could be the div's closing fence. This commit fixes that by keeping track of open code blocks when looking for the closing fence.
It also removes the existing test for this case from the
skipfile.fixes #6