-
Notifications
You must be signed in to change notification settings - Fork 31
ci(labeler): add automatic pull request labeling #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Some new issue labels were added. This change attempts to partially automate the manual effort of labeling, which is otherwise helpful for being able to shift through past PRs concerning specific focus points.
|
This is a proof of concept meant to partially automate labels, I'd like to request for comment (given that I also took the liberty of adding a bunch of new labels) first before testing / working further on this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 28 28
Lines 3324 3324
=======================================
Hits 2563 2563
Misses 761 761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not quite sure if the project is that big, that we have to automatically label our PRs. For me, that feels like this gets relevant once different persons maintain different subsets of the project, which isn't the case for uhyve. But if you feel the need, I'll not oppose it as long as it is just labelling. |
I see your point, but my argument for that is that I tend to look up past PRs or issues (and there are often duplicate issues) in retrospect. I'd say that this is more about bookkeeping and information retention – in the context of 900+ PRs, the project may as well be considered big enough. On the other hand, labeling is manual effort and this just automates like 30%-40% of it. Ballpark numbers. For big projects with components maintained by different people, I'd use |
|
Anyway, I'll test it on my fork and mark it as Ready for review whenever I find the time. |
|
As some time has passed, do you want it to be merged? |
Let's just go for it? :D |
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/labeler@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - uses: actions/labeler@v5 | |
| - uses: actions/labeler@v6 |
Some new issue labels were added. This change attempts to partially automate the manual effort of labeling, which is otherwise helpful for being able to shift through past PRs concerning specific focus points.