feat(isolation): use normalize_lexically for paths #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a TODO for removing clean_path as a dependency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
==========================================
+ Coverage 76.95% 76.97% +0.02%
==========================================
Files 28 28
Lines 3393 3396 +3
==========================================
+ Hits 2611 2614 +3
Misses 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fogti
reviewed
Oct 21, 2025
Contributor
|
You'll have to adjust |
Member
Author
Yeah, it's a very preliminary pull request to demonstrate how I'd remove I'm not sure if we wish to switch to nightly. |
Co-authored-by: Ellen Emilia Anna Zscheile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a TODO for removing clean_path as a dependency.
Feature not stabilized just yet, but made in advance due to #1135.