Improve usability of Target
#821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes the distro name/version fields non-optional, since (a) they will never be `None` in practice (see #820), and (b) it otherwise causes a lot of unnecessary friction for languages that have distro-version-specific binaries and need to use the metadata in multiple places in the buildpack. * Implements `Debug` on `Target`, which unblocks a number of use-cases, such as including the target as part of a buildpack Error enum variant. Fixes #820. GUS-W-15639138.
edmorley
commented
Apr 30, 2024
edmorley
commented
Apr 30, 2024
runesoerensen
approved these changes
Apr 30, 2024
edmorley
commented
Apr 30, 2024
bigkevmcd
pushed a commit
to bigkevmcd/libcnb.rs
that referenced
this pull request
Jul 3, 2024
* Prepare release v0.21.0 * Add additional comment for heroku#821 --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Ed Morley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stringinstead ofOption<String>), since (a) they will never beNonein practice (see Usability issues with theTargettype #820), and (b) it otherwise causes a lot of unnecessary friction for languages that have distro-version-specific binaries and need to use the metadata in multiple places in the buildpack.CloneandDebugonTarget, which unblocks a number of use-cases, such as including the target as part of a buildpack Error enum variant.Fixes #820.
GUS-W-15639138.