fix(regression): remove overly strict invalid tag format check in Swig parser #5691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b fix/8.0.0-1 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 18785924685Details
💛 - Coveralls |
wangjiezhe
added a commit
to wangjiezhe/wangjiezhe.github.io
that referenced
this pull request
Sep 30, 2025
Fix a bug caused by hexojs/hexo#5618 and fixed in hexojs/hexo#5691
3 tasks
2 tasks
stevenjoezhang
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The previous condition
((char !== '%' && next_char === '}') || (char === '%' && next_char !== '}'))(#5618) was too restrictive and incorrectly identified valid tags containing '%' characters (like{% include 11% 22 %}) as invalid format.This change removes the problematic validation and relies on proper tag ending detection (
%}) and the existing backtracking mechanism for handling truly malformed tags.Screenshots
Pull request tasks