Add option to configure task check interval #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzshew
approved these changes
Jul 28, 2023
|
@krhubert can we merge it? Looks like PR is approved and changes are very helpful. |
Contributor
Author
|
@lavrd yeah, please merge it! |
|
I don't have rights to merge, maybe @kamikazechaser or @hibiken can help. |
Collaborator
kamikazechaser
left a comment
There was a problem hiding this comment.
Inline docs suggestion.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 68.34% 68.41% +0.07%
==========================================
Files 27 27
Lines 3829 3841 +12
==========================================
+ Hits 2617 2628 +11
- Misses 928 929 +1
Partials 284 284 ☔ View full report in Codecov by Sentry. |
kamikazechaser
approved these changes
Oct 20, 2023
Collaborator
kamikazechaser
left a comment
There was a problem hiding this comment.
LGTM
cc/ @hibiken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
#506
#548