feat(dash): Add --insecure option #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamikazechaser
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
==========================================
- Coverage 67.13% 66.32% -0.82%
==========================================
Files 29 29
Lines 4300 5740 +1440
==========================================
+ Hits 2887 3807 +920
- Misses 1135 1652 +517
- Partials 278 281 +3 ☔ View full report in Codecov by Sentry. |
divyam234
pushed a commit
to divyam234/asynq
that referenced
this pull request
Dec 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the flag
--insecuretoasynq dashthat works just like the--insecureflag on theredis-cliwhere it doesn't validate the TLS config. This is necessary to be able to connect to some Redis servers that are fronted by a self-signed certificate. This can either be self-hosted or hosted by some providers like Heroku.