-
Notifications
You must be signed in to change notification settings - Fork 113
SSL Support #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SSL Support #37
Conversation
Added SSL Support
|
Thanks a lot @SariSultan I will review it soon :) |
|
This is a very huge PR. Can you explain what you've done with a bit detailed? |
Here the client should verify the server certificate. Currently using matching the server public key with the stored public key on the user side.
|
Thank you @hikalkan. I added SSL/TLS support for server and clients. I tried to be consistent with the original framework. I made few changes to the original files. ### First, changes to the original files: This method allows the user to create and Ssl server. (Parameters will be discussed later) 1.B: This method allows the user to create Ssl client. (Parameters will be discussed later)
2.B: In BinarySerializationProtocol.cs: Those are the only changes to the original framework files. Now lets see the new files added. ### Second, new files in the framework:
Second, mutual authentication: in this type the client verifies the server certificate (similar to the previous steps), but the server should also verify the client certificate. 1.B: channel.tcp: this includes two main classes: 1.C: Client.Tcp: this includes two main classes: 1.D: Server.Tcp: changes here are similar to the changes in (1.C) but for the server. ### Third, new samples: |
|
Is there a chance that this will be merged to a release? I am very interested in that feature. |
No description provided.