Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix grid tile coordinates calculation #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 6 commits into from
Dec 4, 2020
Merged

Fix grid tile coordinates calculation #186

alessiamarcolini merged 6 commits into from
Dec 4, 2020

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Dec 4, 2020

fix #184

ernestoarbitrio
ernestoarbitrio reviewed Dec 4, 2020
View reviewed changes
ernestoarbitrio
ernestoarbitrio reviewed Dec 4, 2020
View reviewed changes
ernestoarbitrio
ernestoarbitrio reviewed Dec 4, 2020
View reviewed changes
ernestoarbitrio
ernestoarbitrio reviewed Dec 4, 2020
View reviewed changes
ernestoarbitrio
ernestoarbitrio requested changes Dec 4, 2020
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments ... after that 👍🏽

@coveralls
Copy link

coveralls commented Dec 4, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d454480 on fix-gridcoordinates into 72a598e on master.

@alessiamarcolini alessiamarcolini force-pushed the fix-gridcoordinates branch 2 times, most recently from 6390ab2 to cb149b1 Compare December 4, 2020 16:54
ernestoarbitrio
ernestoarbitrio approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessiamarcolini alessiamarcolini merged commit e126fce into master Dec 4, 2020
@alessiamarcolini alessiamarcolini deleted the fix-gridcoordinates branch December 4, 2020 18:13
@ernestoarbitrio ernestoarbitrio added 0.2.2 bug Something isn't working and removed 0.2.2 labels Jan 7, 2021
@ernestoarbitrio ernestoarbitrio added CI and removed 0.2.2 labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Biggest tissue box coordinates are inverted (PIL -> NumPy)

4 participants

@alessiamarcolini @coveralls @ernestoarbitrio