Raise TileSizeError if the tile size is larger than the slide size #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d18206 to
38fcf4f
Compare
ernestoarbitrio
requested changes
Jan 2, 2021
Member
ernestoarbitrio
left a comment
There was a problem hiding this comment.
General comment:
considering that you are repeating the same check in each tiler class i'd like to include it in the Tiler class :
def check_something(self):
return (self.tile_size[0] > slide.level_dimensions(self.level)[0] or self.tile_size[1] > slide.level_dimensions(self.level)[1])and then check for this prop in each subclass
38fcf4f to
5518ff2
Compare
5518ff2 to
6ffa26c
Compare
ernestoarbitrio
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #192
AND check in
Tiler.extract()if the level is available