Fix has only some tissue using image rather than mask for calculating the variance#203
Merged
alessiamarcolini merged 6 commits intomasterfrom Dec 31, 2020
Merged
Conversation
alessiamarcolini
requested changes
Dec 30, 2020
Collaborator
alessiamarcolini
left a comment
There was a problem hiding this comment.
test to be placed in the correct module
| Parameters | ||
| ---------- | ||
| near_zero_var_threshold : float, optional | ||
| min_var : float, optional |
Collaborator
There was a problem hiding this comment.
now the docstring is not correct because it refers to the old filters that were applied
afb55b0 to
31d9cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #193