Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix has only some tissue using image rather than mask for calculating the variance #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 6 commits into from
Dec 31, 2020
Merged

Fix has only some tissue using image rather than mask for calculating the variance #203

alessiamarcolini merged 6 commits into from
Dec 31, 2020

Conversation

@ernestoarbitrio
Copy link
Member

@ernestoarbitrio ernestoarbitrio commented Dec 30, 2020

Fix: #193

@coveralls
Copy link

coveralls commented Dec 30, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 31d9cc8 on fix-has-only-some-tissue into b230146 on master.

alessiamarcolini
alessiamarcolini requested changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test to be placed in the correct module

alessiamarcolini
alessiamarcolini reviewed Dec 31, 2020
View reviewed changes
src/histolab/tile.py
Parameters
----------
near_zero_var_threshold : float, optional
min_var : float, optional
Copy link
Collaborator

@alessiamarcolini alessiamarcolini Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the docstring is not correct because it refers to the old filters that were applied

@ernestoarbitrio ernestoarbitrio force-pushed the fix-has-only-some-tissue branch from afb55b0 to 31d9cc8 Compare December 31, 2020 11:56
alessiamarcolini
alessiamarcolini approved these changes Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alessiamarcolini alessiamarcolini merged commit 7c64c36 into master Dec 31, 2020
@alessiamarcolini alessiamarcolini deleted the fix-has-only-some-tissue branch December 31, 2020 12:33
@ernestoarbitrio ernestoarbitrio added the enhancement New feature or request label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alessiamarcolini alessiamarcolini alessiamarcolini approved these changes

Assignees

No one assigned

Labels

CI enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RandomTiler border wackiness extraction

4 participants

@ernestoarbitrio @coveralls @alessiamarcolini