Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alessiamarcolini
Copy link
Collaborator

fixes #225

@coveralls
Copy link

coveralls commented Feb 9, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 27b159f on slide-pathlib into 6febdd8 on master.

Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments left

@ernestoarbitrio ernestoarbitrio added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 10, 2021
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a further minor comment

Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ernestoarbitrio ernestoarbitrio merged commit 4f59b9a into master Feb 16, 2021
@ernestoarbitrio ernestoarbitrio deleted the slide-pathlib branch February 16, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slide accepting pathlib.Path as path of slide on disk

4 participants