Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow pathlib.Path as Slide path paramerer #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ernestoarbitrio merged 5 commits into from
Feb 16, 2021
Merged

Allow pathlib.Path as Slide path paramerer #226

ernestoarbitrio merged 5 commits into from
Feb 16, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Feb 9, 2021

fixes #225

@coveralls
Copy link

coveralls commented Feb 9, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 27b159f on slide-pathlib into 6febdd8 on master.

ernestoarbitrio
ernestoarbitrio reviewed Feb 10, 2021
View reviewed changes
ernestoarbitrio
ernestoarbitrio reviewed Feb 10, 2021
View reviewed changes
ernestoarbitrio
ernestoarbitrio reviewed Feb 10, 2021
View reviewed changes
ernestoarbitrio
ernestoarbitrio requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments left

@ernestoarbitrio ernestoarbitrio added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 10, 2021
ernestoarbitrio
ernestoarbitrio requested changes Feb 15, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a further minor comment

ernestoarbitrio
ernestoarbitrio approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ernestoarbitrio ernestoarbitrio merged commit 4f59b9a into master Feb 16, 2021
@ernestoarbitrio ernestoarbitrio deleted the slide-pathlib branch February 16, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

@alessiamarcolini alessiamarcolini

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Slide accepting pathlib.Path as path of slide on disk

4 participants

@alessiamarcolini @coveralls @ernestoarbitrio