Codecov Report

Merging #268 (ed15e91) into master (acc0f82) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1207      1207           
  Branches       114       114           
=========================================
  Hits          1207      1207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc0f82...ed15e91. Read the comment docs.

General comment, why move a polygon to a rectangle for the mask array operation? @alessiamarcolini can you give me a rationale of this choice?

I changed the naming because a polygon can have more than 4 vertices and we explicitly require a CoordinatePair which corresponds to 4 vertices. Probably a more appropriate name would be "quadrilateral" but to me it's a bit ugly... @ernestoarbitrio what do you think?

I changed the naming because a polygon can have more than 4 vertices and we explicitly require a CoordinatePair which corresponds to 4 vertices. Probably a more appropriate name would be "quadrilateral" but to me it's a bit ugly... @ernestoarbitrio what do you think?

gotcha , I would say that your name is absolutely appropriate. So let's keep it