Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add tutorial for masks #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 7 commits into from
Apr 27, 2021
Merged

add tutorial for masks #260

alessiamarcolini merged 7 commits into from
Apr 27, 2021

Conversation

@nicolebussola
Copy link
Collaborator

@nicolebussola nicolebussola commented Apr 26, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2021 •
edited
Loading

Codecov Report

Merging #260 (48f6cad) into master (4f75962) will not change coverage.
The diff coverage is n/a.

❗ Current head 48f6cad differs from pull request most recent head bcf2241. Consider uploading reports for the commit bcf2241 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1207      1207           
  Branches       114       114           
=========================================
  Hits          1207      1207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f75962...bcf2241. Read the comment docs.

alessiamarcolini
alessiamarcolini requested changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is generally ok; however I would prefer having two sections describing the two masks separately, as it will be easier to modify and extend this tutorial whenever we will have more masks to present

@alessiamarcolini alessiamarcolini linked an issue Apr 26, 2021 that may be closed by this pull request
Fix README and Quickstart after BiggestTissueBoxMask implementation #244
Closed
@nicolebussola nicolebussola linked an issue Apr 27, 2021 that may be closed by this pull request
Quickstart refactoring #249
Closed
@alessiamarcolini
Copy link
Collaborator

alessiamarcolini commented Apr 27, 2021

@nicolebussola can you rebase this on master?

@alessiamarcolini alessiamarcolini merged commit b6dcc60 into master Apr 27, 2021
@alessiamarcolini alessiamarcolini deleted the fix_quickstart branch April 27, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alessiamarcolini alessiamarcolini alessiamarcolini approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quickstart refactoring Fix README and Quickstart after BiggestTissueBoxMask implementation

3 participants

@nicolebussola @alessiamarcolini