Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix overlapping extraction grids in GridTiler #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ernestoarbitrio merged 13 commits into from
Jul 6, 2021
Merged

Fix overlapping extraction grids in GridTiler #270

ernestoarbitrio merged 13 commits into from
Jul 6, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented May 30, 2021 •
edited
Loading

fixes #266

@alessiamarcolini alessiamarcolini added the bug Something isn't working label May 30, 2021
@alessiamarcolini alessiamarcolini marked this pull request as draft May 30, 2021 10:30
@codecov
Copy link

codecov bot commented May 30, 2021 •
edited
Loading

Codecov Report

Merging #270 (f1f6c6d) into master (22cc4fa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1217      1236   +19     
  Branches       115       117    +2     
=========================================
+ Hits          1217      1236   +19
Impacted Files Coverage Δ
src/histolab/tiler.py 100.00% <100.00%> (ø)
src/histolab/types.py 100.00% <100.00%> (ø)
src/histolab/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cc4fa...f1f6c6d. Read the comment docs.

@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch 2 times, most recently from c46cbe3 to d1ed18f Compare June 1, 2021 15:09
@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch from d1ed18f to b2e8ac0 Compare June 13, 2021 21:39
@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch 7 times, most recently from e084daa to 4e4762f Compare June 24, 2021 13:24
@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch from aaa28a2 to 86f6982 Compare June 28, 2021 11:43
@alessiamarcolini alessiamarcolini marked this pull request as ready for review June 29, 2021 18:34
@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch 2 times, most recently from 997180c to bf1f161 Compare June 29, 2021 19:03
@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch from bf1f161 to 6ba1fad Compare June 29, 2021 19:04
@ernestoarbitrio ernestoarbitrio changed the title WIP: Fix overlapping extraction grids in GridTiler Fix overlapping extraction grids in GridTiler Jun 30, 2021
ernestoarbitrio
ernestoarbitrio requested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per comments

@ernestoarbitrio ernestoarbitrio added this to the 0.2.6 milestone Jun 30, 2021
ernestoarbitrio
ernestoarbitrio reviewed Jun 30, 2021
View reviewed changes
ernestoarbitrio
ernestoarbitrio approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : look at the stupid comment please

nicolebussola
nicolebussola reviewed Jul 5, 2021
View reviewed changes
nicolebussola
nicolebussola reviewed Jul 5, 2021
View reviewed changes
nicolebussola
nicolebussola reviewed Jul 5, 2021
View reviewed changes
src/histolab/tiler.py
def _grid_coordinates_from_bbox_coordinates(
self, bbox_coordinates: CoordinatePair, slide: Slide
self,
bbox_coordinates_lvl: CoordinatePair,
Copy link
Collaborator

@nicolebussola nicolebussola Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why _lvl?

Copy link
Collaborator Author

@alessiamarcolini alessiamarcolini Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the naming, they were the coordinates at the level of extraction before as well

nicolebussola
nicolebussola reviewed Jul 5, 2021
View reviewed changes
nicolebussola
nicolebussola reviewed Jul 5, 2021
View reviewed changes
nicolebussola
nicolebussola reviewed Jul 5, 2021
View reviewed changes
nicolebussola
nicolebussola requested changes Jul 5, 2021
View reviewed changes
Copy link
Collaborator

@nicolebussola nicolebussola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch from 33d1afd to cf5d924 Compare July 5, 2021 16:06
@alessiamarcolini alessiamarcolini force-pushed the fix-overlapping-extraction-grids branch from 41005e1 to f1f6c6d Compare July 5, 2021 16:43
nicolebussola
nicolebussola approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@nicolebussola nicolebussola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestoarbitrio ernestoarbitrio merged commit 5178120 into master Jul 6, 2021
@ernestoarbitrio ernestoarbitrio deleted the fix-overlapping-extraction-grids branch July 6, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

@nicolebussola nicolebussola nicolebussola approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.2.6

Development

Successfully merging this pull request may close these issues.

GridTiler with multiple tissue regions uses overlapping extraction grids

4 participants

@alessiamarcolini @ernestoarbitrio @nicolebussola