Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add black in CI #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ernestoarbitrio merged 3 commits into from
Jul 13, 2021
Merged

Add black in CI #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
655c46f
add black to ci
ernestoarbitrio Jul 13, 2021
1b66304
increase benchmanrk threshold
ernestoarbitrio Jul 13, 2021
995f75d
pin black and flake8 version in ci workflow to be compliant with pre-…
ernestoarbitrio Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ jobs:
fail-on-alert: true
comment-on-alert: true
alert-comment-cc-users: '@ernestoarbitrio'
alert-threshold: '200%'
alert-threshold: '300%'
8 changes: 7 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,15 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install -e .[testing]
python -m pip install flake8
python -m pip install flake8==3.8.4
python -m pip install black==21.6b0
python -m pip install pooch

- name: Black Code Style Format Check
id: black
run: |
black . --check

- name: Lint with flake8
id: flake8
run: |
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/ambv/black
rev: 20.8b1
rev: 21.6b0
hooks:
- id: black
language_version: python3.8
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/data/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def test_download_file_from_internet_but_it_is_broken():


def test_cmu_small_region():
""" Test that "cmu_small_region" svs can be loaded. """
"""Test that "cmu_small_region" svs can be loaded."""
cmu_small_region_image, path = cmu_small_region()
assert cmu_small_region_image.dimensions == (2220, 2967)

Expand Down