Finer control of locate_tiles #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1251 1264 +13
Branches 118 124 +6
=========================================
+ Hits 1251 1264 +13
Continue to review full report at Codecov.
|
|
Hey @kheffah thanks for this PR!! First of all, could you split this commit into 3 separate commits? |
|
@alessiamarcolini All done :) |
ernestoarbitrio
left a comment
There was a problem hiding this comment.
@kheffah thanks for this contribution. That's great. Just a couple of comments
ernestoarbitrio
left a comment
There was a problem hiding this comment.
Per comments, please let me know if something is not clear enough
ernestoarbitrio
left a comment
There was a problem hiding this comment.
I think we're close. Could you address my last comments please :D
alessiamarcolini
left a comment
There was a problem hiding this comment.
some stylistic changes + unit test code shouldn't have conditionals (see comments)
…s to avoid re-extraction, 2. optionally not fading image, 3. passing individual colors to specific tiles (eg to emphasize specific regions of interest).
This reverts commit a636668. Instead we will default alpha to 255 to avoid unnecessary if statement.
…ument of locate_tiles and use generators instead
c1bd0b4 to
2829ddd
Compare
shorter line in DescribeRandomTiler shorter line in DescribeRandomTiler
Co-authored-by: Alessia Marcolini <[email protected]>
2829ddd to
b88f31e
Compare
383694e to
8a1aff9
Compare
Finer control of locate_tiles including
Types of Changes
Checklist