Codecov Report

Merging #300 (063b104) into master (29ebb9a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1328      1331    +3     
  Branches       133       134    +1     
=========================================
+ Hits          1328      1331    +3     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ebb9a...063b104. Read the comment docs.

@alessiamarcolini OK, all done 👍🏻

@kheffah could you please squash all the "update" commit into a single one? Thanks!!

PS there is a way to add all the suggestions to a single commit from the interface directly

@alessiamarcolini Oops I didn't know that. OK, now commit aaf4a09 contains the squashed changes.

Hi @kheffah, sorry I meant to do an interactive rebase to rewrite history and have only the relevant commits (with a proper message) to have a clean history. Please let me know if you need any help with this :)

Hi @kheffah, sorry I meant to do an interactive rebase to rewrite history and have only the relevant commits (with a proper message) to have a clean history. Please let me know if you need any help with this :)

Yes please, I've never done that before. I'm dealing with a deadline at the moment so maybe at least a few days till I get to it. If you prefer to get it done quickly, feel free to do it :)

@alessiamarcolini OK I officially give up 😆 Everytime I do the interactive rebase locally I get a conflict, asks me to resolve it, asks me to pull, and then when the rebase succeeds and I push, I still see the commits. I could probably fix this if I spend more time on it but I have high priority research tasks at the time being. But feel free to do it if you'd like, sorry about that.

@kheffah I think after these last comments from me and @alessiamarcolini this PR should be ready to go :D Thanks for your work

I also asked a review to @nicolebussola if she has time ;)

Oh ... got it, but I think 2 reviews are more than enough 😄

@alessiamarcolini @ernestoarbitrio Thanks! All suggestions incorporated now.