Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add method dispatcher compatible with older Python versions #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 1 commit into from
Aug 18, 2021
Merged

Add method dispatcher compatible with older Python versions #312

alessiamarcolini merged 1 commit into from
Aug 18, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Aug 18, 2021 •
edited
Loading

Description

This is an implementation of a type dispatcher for methods.

functools.singledispatcher is dispatching on the type of the first argument, which, for methods, is always self.

Therefore, in order to implement #311, I needed a method dispatcher compatible with all Python versions (functools.singledispatchmethod is only available for Python 3.8+)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #312 (e2e8824) into master (79e9792) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1264      1272    +8     
  Branches       124       124           
=========================================
+ Hits          1264      1272    +8
Impacted Files Coverage Δ
src/histolab/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e9792...e2e8824. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit f86c65e into master Aug 18, 2021
@alessiamarcolini alessiamarcolini deleted the tissue-mask-tile-dispatcher branch August 18, 2021 13:31
@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2021

This pull request introduces 1 alert when merging e2e8824 into 79e9792 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio