Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement TissueMask mask for Tile with type dispatcher #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 14 commits into from
Aug 23, 2021
Merged

Implement TissueMask mask for Tile with type dispatcher #313

alessiamarcolini merged 14 commits into from
Aug 23, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Aug 18, 2021 •
edited
Loading

Description

Now is possible to use the TissueMask mask also on Tiles:

from histolab.masks import TissueMask
from histolab.tile import Tile

tile = Tile(pil_img, None, None)
tissue_mask = TissueMask()

result = tissue_mask(tile) # same dimensions as the tile

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added the enhancement New feature or request label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #313 (c557145) into master (a7dc352) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1272      1284   +12     
  Branches       124       124           
=========================================
+ Hits          1272      1284   +12
Impacted Files Coverage Δ
src/histolab/filters/compositions.py 100.00% <100.00%> (ø)
src/histolab/masks.py 100.00% <100.00%> (ø)
src/histolab/slide.py 100.00% <100.00%> (ø)
src/histolab/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7dc352...c557145. Read the comment docs.

ernestoarbitrio
ernestoarbitrio requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the minor comment

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2021

This pull request fixes 1 alert when merging 959b712 into f86c65e - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@alessiamarcolini
Copy link
Collaborator Author

alessiamarcolini commented Aug 20, 2021

hey @ernestoarbitrio what do I do with this CodeFactor issue?

src/histolab/filters/compositions.py#L91
Unnecessary pass statement (unnecessary-pass)

I wanted that method for the sake of the documentation, can I achieve the same result in another way?

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request fixes 1 alert when merging 7df6bac into f86c65e - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request fixes 1 alert when merging f187c3c into f86c65e - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

ernestoarbitrio
ernestoarbitrio requested changes Aug 20, 2021
View reviewed changes
@alessiamarcolini alessiamarcolini force-pushed the tissue-mask-tile branch 2 times, most recently from 8da21db to a1cc719 Compare August 23, 2021 11:54
@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2021

This pull request fixes 1 alert when merging a1cc719 into f86c65e - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2021

This pull request fixes 1 alert when merging 6c3ae1a into f86c65e - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2021

This pull request fixes 1 alert when merging 138c3f2 into f86c65e - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

ernestoarbitrio
ernestoarbitrio reviewed Aug 23, 2021
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2021

This pull request fixes 1 alert when merging c557145 into a7dc352 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@ernestoarbitrio ernestoarbitrio added this to the 0.2.7 milestone Aug 23, 2021
@alessiamarcolini alessiamarcolini merged commit 6625b40 into master Aug 23, 2021
@alessiamarcolini alessiamarcolini deleted the tissue-mask-tile branch August 23, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request ready-for-merge

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

TissueMask mask on Tile

3 participants

@alessiamarcolini @ernestoarbitrio