Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Get rid of src directory in favor of histolab dir within the root #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ernestoarbitrio merged 1 commit into from
Oct 6, 2021
Merged

Get rid of src directory in favor of histolab dir within the root #324

ernestoarbitrio merged 1 commit into from
Oct 6, 2021

Conversation

@ernestoarbitrio
Copy link
Member

@ernestoarbitrio ernestoarbitrio commented Oct 4, 2021

Considering the general footprint of the majority of the python projects I get rid of the src folder that seems more related to C or Java projects and keep the project name as source folder.

Detail
mv src/* ../histolab

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ernestoarbitrio ernestoarbitrio added this to the 0.2.7 milestone Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited
Loading

Codecov Report

Merging #324 (026d01d) into master (06204cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1307      1307           
  Branches       127       127           
=========================================
  Hits          1307      1307
Impacted Files Coverage Δ
histolab/__init__.py 100.00% <ø> (ø)
histolab/data/__init__.py 100.00% <ø> (ø)
histolab/data/_registry.py 100.00% <ø> (ø)
histolab/exceptions.py 100.00% <ø> (ø)
histolab/filters/compositions.py 100.00% <ø> (ø)
histolab/filters/image_filters.py 100.00% <ø> (ø)
histolab/filters/image_filters_functional.py 100.00% <ø> (ø)
histolab/filters/morphological_filters.py 100.00% <ø> (ø)
...stolab/filters/morphological_filters_functional.py 100.00% <ø> (ø)
histolab/filters/util.py 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06204cc...026d01d. Read the comment docs.

@alessiamarcolini
Copy link
Collaborator

alessiamarcolini commented Oct 5, 2021

@ernestoarbitrio if you rebase on master we can proceed with the merge 🚀

@ernestoarbitrio ernestoarbitrio force-pushed the refactor-project-dir-structure branch from b64a611 to 026d01d Compare October 6, 2021 09:22
@ernestoarbitrio ernestoarbitrio merged commit 5ebbc8a into master Oct 6, 2021
@ernestoarbitrio ernestoarbitrio deleted the refactor-project-dir-structure branch October 6, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alessiamarcolini alessiamarcolini alessiamarcolini approved these changes

Assignees

No one assigned

Labels

best practice

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ernestoarbitrio @alessiamarcolini