Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add filter LabToRgb e fix return image in RgbToLab #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 13 commits into from
Nov 4, 2021
Merged

Add filter LabToRgb e fix return image in RgbToLab #323

alessiamarcolini merged 13 commits into from
Nov 4, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Sep 28, 2021 •
edited
Loading

Description

In order to implement #322, we need to convert back from the LAB space to the RGB space.

Moreover, it fixes a bug in the filter RgbToLab, where by mistake the resulting Lab image was converted to a PIL image, messing up the value range and type (it should be float in the range −128 to 127).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added bug Something isn't working enhancement New feature or request labels Sep 28, 2021
@alessiamarcolini alessiamarcolini changed the title Filter LabToRgb Add filter LabToRgb e fix return image in RgbToLab Sep 28, 2021
ernestoarbitrio
ernestoarbitrio requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 easy comments ,... than LGTM

@alessiamarcolini alessiamarcolini force-pushed the filter-lab_to_rgb branch 3 times, most recently from 4272e4b to 5e207d2 Compare November 2, 2021 14:01
@alessiamarcolini
Copy link
Collaborator Author

alessiamarcolini commented Nov 2, 2021

PR #334 needs to be merged first

@codecov
Copy link

codecov bot commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #323 (72368bd) into master (a7d48b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #323   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1313      1324   +11     
  Branches       128       128           
=========================================
+ Hits          1313      1324   +11
Impacted Files Coverage Δ
histolab/filters/image_filters.py 100.00% <100.00%> (ø)
histolab/filters/image_filters_functional.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d48b8...72368bd. Read the comment docs.

ernestoarbitrio
ernestoarbitrio requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 single comment then LGTM

@alessiamarcolini alessiamarcolini merged commit 17d1e0e into master Nov 4, 2021
@alessiamarcolini alessiamarcolini deleted the filter-lab_to_rgb branch November 4, 2021 14:07
@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio