Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RgbToOd filter return np array with correct range and use correct formula #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 6 commits into from
Oct 15, 2021
Merged

RgbToOd filter return np array with correct range and use correct formula #331

alessiamarcolini merged 6 commits into from
Oct 15, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Oct 14, 2021 •
edited
Loading

Description

RgbToOd filter return np array with correct range and use correct formula

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added the bug Something isn't working label Oct 14, 2021
@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #331 (a4a4129) into master (437aa84) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1310      1308    -2     
  Branches       128       128           
=========================================
- Hits          1310      1308    -2
Impacted Files Coverage Δ
histolab/filters/image_filters.py 100.00% <100.00%> (ø)
histolab/filters/image_filters_functional.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437aa84...a4a4129. Read the comment docs.

ernestoarbitrio
ernestoarbitrio requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small changes than LGTM

@alessiamarcolini alessiamarcolini merged commit e1e9f7a into master Oct 15, 2021
@alessiamarcolini alessiamarcolini deleted the fix-rgb-to-od branch October 15, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio