Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove HSV and YCBCR references in wrong value range #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ernestoarbitrio merged 2 commits into from
Nov 5, 2021
Merged

Remove HSV and YCBCR references in wrong value range #343

ernestoarbitrio merged 2 commits into from
Nov 5, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Nov 4, 2021 •
edited
Loading

Description

Remove tests, fixtures and expectations with images in HSV and YCBCR wrongly converted to RGB.
This doesn't impact the codebase, only the tests.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Nov 4, 2021
ernestoarbitrio
ernestoarbitrio approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would wait for the CI before merging it

@ernestoarbitrio ernestoarbitrio force-pushed the remove-hsv-ycbcr-references branch from f5f4150 to 0b07d89 Compare November 5, 2021 08:51
@alessiamarcolini
Copy link
Collaborator Author

alessiamarcolini commented Nov 5, 2021

@ernestoarbitrio I see now that it's running, great

@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited
Loading

Codecov Report

Merging #343 (0b07d89) into master (b3e1563) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1324      1324           
  Branches       128       128           
=========================================
  Hits          1324      1324

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e1563...0b07d89. Read the comment docs.

@ernestoarbitrio ernestoarbitrio merged commit fb5368a into master Nov 5, 2021
@alessiamarcolini alessiamarcolini deleted the remove-hsv-ycbcr-references branch November 18, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio