Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix link to installation instructions #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 1 commit into from
Nov 16, 2021
Merged

Fix link to installation instructions #350

alessiamarcolini merged 1 commit into from
Nov 16, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Nov 16, 2021 •
edited
Loading

Description

Per title

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added the documentation Improvements or additions to documentation label Nov 16, 2021
@alessiamarcolini alessiamarcolini added this to the 0.4.0 milestone Nov 16, 2021
ernestoarbitrio
ernestoarbitrio requested changes Nov 16, 2021
View reviewed changes
docs/index.rst
Prerequisites
*************
Please see `installation instructions <https://github.com/histolab/histolab/blob/master/docs/installation.rst>`_.
Please see `installation instructions <installation.html>`_.
Copy link
Member

@ernestoarbitrio ernestoarbitrio Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link doesn't exsist 🤷🏽

Copy link
Collaborator Author

@alessiamarcolini alessiamarcolini Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean? if you check the docs build it works

@codecov
Copy link

codecov bot commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #350 (49ce2c1) into master (7463921) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #350   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1407      1407           
  Branches       152       152           
=========================================
  Hits          1407      1407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7463921...49ce2c1. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit 7f57e63 into master Nov 16, 2021
@alessiamarcolini alessiamarcolini deleted the fix-docs-installation branch November 16, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio