Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix SlideSet not passing along args to Slide #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 1 commit into from
Nov 18, 2021
Merged

Fix SlideSet not passing along args to Slide #351

alessiamarcolini merged 1 commit into from
Nov 18, 2021

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Nov 18, 2021 •
edited
Loading

Description

Per title

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added this to the 0.4.0 milestone Nov 18, 2021
@alessiamarcolini alessiamarcolini added the bug Something isn't working label Nov 18, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021 •
edited
Loading

Codecov Report

Merging #351 (f0ceec2) into master (7f57e63) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #351   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1407      1408    +1     
  Branches       152       152           
=========================================
+ Hits          1407      1408    +1
Impacted Files Coverage Δ
histolab/slide.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f57e63...f0ceec2. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit 943dbb7 into master Nov 18, 2021
@alessiamarcolini alessiamarcolini deleted the fix-parameter-passing-slideset branch November 18, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

Expected bug - SlideSet not passing along args to Slide

3 participants

@alessiamarcolini @ernestoarbitrio