Tissue mask on Tile is sharper
#364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1411 1411
Branches 218 218
=========================================
Hits 1411 1411
Continue to review full report at Codecov.
|
ernestoarbitrio
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces little modifications to the parameters of the filters used to calculate the tissue mask on the
Tile, in order to have a sharper mask.This is necessary for the implementation of the method of Reinhard for stain normalization (#322), because it calculates means/std on tissue and it needs to be as precise as possible.
Example
Tile in tests/expectations/tiles/tissue-level0-4302-10273-4814-10785.png
Before
After
Types of Changes
Issues Fixed or Closed by This PR
Checklist