Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow custom filters in BiggestTissueBoxMask #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 3 commits into from
Apr 1, 2022
Merged

Allow custom filters in BiggestTissueBoxMask #387

alessiamarcolini merged 3 commits into from
Apr 1, 2022

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Mar 8, 2022 •
edited
Loading

Co-authored-by: ernestoarbitrio [email protected]

Description

Allow custom filters in BiggestTissueBoxMask. Follow-up of #377

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added the enhancement New feature or request label Mar 8, 2022
@alessiamarcolini alessiamarcolini added this to the 0.5.0 milestone Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #387 (9368d9f) into master (ced1239) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1430      1433    +3     
  Branches       222       223    +1     
=========================================
+ Hits          1430      1433    +3
Impacted Files Coverage Δ
histolab/masks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced1239...9368d9f. Read the comment docs.

@alessiamarcolini alessiamarcolini force-pushed the custom-filters-biggesttissueboxmask branch from b741d88 to b20fb2e Compare April 1, 2022 10:52
@alessiamarcolini alessiamarcolini force-pushed the custom-filters-biggesttissueboxmask branch from b20fb2e to eadb59b Compare April 1, 2022 11:31
ernestoarbitrio
ernestoarbitrio approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But please check the comments

@alessiamarcolini alessiamarcolini merged commit 20790ff into master Apr 1, 2022
@alessiamarcolini alessiamarcolini deleted the custom-filters-biggesttissueboxmask branch April 1, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

@nicolebussola nicolebussola Awaiting requested review from nicolebussola

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio