Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix black dependency issue #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 4 commits into from
Apr 1, 2022
Merged

Fix black dependency issue #389

alessiamarcolini merged 4 commits into from
Apr 1, 2022

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Apr 1, 2022 •
edited
Loading

Description

Update black to fix issue with broken click dependency.
See psf/black#2964

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Fixes:

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added this to the 0.5.0 milestone Apr 1, 2022
@alessiamarcolini alessiamarcolini added dependencies Pull requests that update a dependency file bug Something isn't working labels Apr 1, 2022
@alessiamarcolini alessiamarcolini changed the title Update .pre-commit-config.yaml to fix black dependency issue Fix black dependency issue Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022 •
edited
Loading

Codecov Report

Merging #389 (eff7306) into master (76f8622) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1430      1430           
  Branches       222       222           
=========================================
  Hits          1430      1430
Impacted Files Coverage Δ
histolab/slide.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f8622...eff7306. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit ced1239 into master Apr 1, 2022
@alessiamarcolini alessiamarcolini deleted the fix-black branch April 1, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alessiamarcolini @ernestoarbitrio