Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix bug of thumbnail dimensions when using large_image #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alessiamarcolini merged 2 commits into from
Apr 1, 2022
Merged

Fix bug of thumbnail dimensions when using large_image #390

alessiamarcolini merged 2 commits into from
Apr 1, 2022

Conversation

@alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Apr 1, 2022 •
edited
Loading

Description

Now the thumbnail dimension is the same when using openslide or large_image as backend

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini added the bug Something isn't working label Apr 1, 2022
@alessiamarcolini alessiamarcolini added this to the 0.5.0 milestone Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022 •
edited
Loading

Codecov Report

Merging #390 (4df2c05) into master (20790ff) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1433      1433           
  Branches       223       223           
=========================================
  Hits          1433      1433
Impacted Files Coverage Δ
histolab/slide.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20790ff...4df2c05. Read the comment docs.

@alessiamarcolini alessiamarcolini merged commit 48959dc into master Apr 1, 2022
@alessiamarcolini alessiamarcolini deleted the fix-largeimage-thumb branch April 1, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

inconsistent behaviour of TissueMask

3 participants

@alessiamarcolini @ernestoarbitrio