Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Largo
Copy link
Contributor

@Largo Largo commented May 22, 2024

@Largo Largo marked this pull request as ready for review May 22, 2024 07:50
@Largo Largo force-pushed the feature/552-sort-roletypes branch from cf2e41d to e436e10 Compare May 22, 2024 09:29
@Largo Largo changed the title Feature/552 sort roletypes ROLES: Sortierung der Rollentypen im Auswahlmenü hitobito/hitobito_sac_cas#552 May 22, 2024
@Largo Largo force-pushed the feature/552-sort-roletypes branch from e436e10 to 12a12b0 Compare May 22, 2024 09:39
Copy link
Member

@nilsrauch nilsrauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schaut gut aus :)

[:'group/top_group/group_manager', 'Group manager', 'E'],
[:'group/top_group/member', 'Member', 'M'],
[:'group/top_group/invisible_people_manager', 'Invisible people manager', 'G'],
[:'role/external', 'External', 'H']].each do |values|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[:'role/external', 'External', 'H']].each do |values|
[:'role/external', 'External', 'H']].each do |class_path, class_name, sort_key|

Dann ist das glaub etwas leserlicher

@Largo Largo force-pushed the feature/552-sort-roletypes branch from 12a12b0 to 92658f3 Compare May 29, 2024 07:08
@Largo Largo self-assigned this May 29, 2024
@Largo Largo merged commit 85c0898 into master May 29, 2024
@Largo Largo deleted the feature/552-sort-roletypes branch May 29, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants