🔨 [tuning] Optimize utils using built-in func and list comprehension #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks correct. Job well done |
baseplate-admin
approved these changes
Apr 30, 2024
Owner
Author
Thanks for your review! Merging. |
hitblast
added a commit
that referenced
this pull request
Dec 16, 2025
🔨 [tuning] Optimize utils using built-in func and list comprehension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes:
count_vowels()andcount_consonants()inside the utils package (avro/utils/count.py) so that they use the built-insum()function, along with list comprehension to quickly scroll through the provided inventory variables on runtime.Attempts to fix: #31