Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@luanlorenzo
Copy link
Contributor

@luanlorenzo luanlorenzo commented Dec 15, 2025

πŸ“ Description

This pull request introduces UI selector for secrets manager providers to simplify role credentials configuration.

πŸš€ Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • 🎨 Style/UI update
  • ♻️ Code refactor
  • ⚑ Performance improvement
  • βœ… Test update
  • πŸ”§ Build configuration change
  • 🧹 Chore

πŸ“‹ Changes Made

Connection Method and Credential Source Handling:

  • Added webapp/connections/views/setup/connection_method.cljs with logic to normalize credential values, infer connection method from sources, and provide UI components for selecting connection method and source. This includes support for manual input, secrets manager, and AWS IAM role, as well as source selectors for environment variable inputs.
  • Refactored event handling in events/db_events.cljs to store network credentials as maps with both value and source, and to infer/update the credential source based on the selected connection method or secrets manager provider.

Environment Variables Input Improvements:

  • Updated configuration_inputs.cljs to conditionally render input fields with a left adornment (source selector) when secrets manager is selected, allowing users to choose the source for each environment variable. Also added logic to hide default titles/subtitles when needed. [1] [2]

Form Components Enhancement:

  • Added input-with-adornment to forms.cljs, a new input component supporting start adornments (such as a dropdown for source selection), and refactored password visibility toggling logic for better reuse.

Documentation Link Updates:

  • Updated documentation URLs in config.cljs to include a new reference for RDS IAM authentication setup.

Module Imports and Integration:

  • Integrated the new connection-method module across relevant files for environment variable and event handling. [1] [2]

πŸ§ͺ Testing

Test Configuration:

  • Browser(s): Chrome
  • OS: MacOs

Tests performed:

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed

πŸ“Έ Screenshots (if applicable)

image image image

βœ… Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@luanlorenzo luanlorenzo self-assigned this Dec 15, 2025
@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-c0298ba

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-8774e04

Copy link
Contributor

@matheusfrancisco matheusfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that our shadow-cljs config doesn't explicitly set the ClojureScript version, which means it defaults to whatever version shadow-cljs uses. I'd recommend we explicitly specify it because certain features depend on the version.
For example, update-vals is only available in ClojureScript β‰₯ 1.11.60. Since ClojureScript is backward compatible, upgrading shouldn't break anything in our frontend webapp.
We should add this to our :dependencies in shadow-cljs.edn:
clojure:dependencies
[[org.clojure/clojurescript "1.11.60"]
...]
Reference: https://github.com/hoophq/hoop/blob/main/webapp/shadow-cljs.edn#L5
Without explicitly setting the version, we're at the mercy of shadow-cljs's default, which might not include update-vals or other newer features we need.

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-04316dc

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-ba556ec

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-ba34955

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-f7d196f

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-fdd4bc8

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-e957bf3

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-6980338

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-76d5d2f

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-e348777

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-390c405

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-39371d4

@rogefm

This comment was marked as resolved.

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-153246e

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-043448b

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-faae50a

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-3e7d282

@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-660e930

@luanlorenzo luanlorenzo requested a review from rogefm January 5, 2026 13:54
@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1193.0.0-3c0b7ae

@luanlorenzo luanlorenzo merged commit 688df4f into main Jan 6, 2026
20 checks passed
@luanlorenzo luanlorenzo deleted the luan/eng-38-new-ux-for-secrets-manager-integration branch January 6, 2026 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants