Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@luanlorenzo
Copy link
Contributor

πŸ“ Description

This pull request updates the logic for generating runbook folder options in the runbook rule form, allowing the UI to present all nested folder paths for each runbook file instead of just the top-level folder. This improves the granularity and flexibility of folder-based selections in the runbook rule setup.

πŸš€ Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • 🎨 Style/UI update
  • ♻️ Code refactor
  • ⚑ Performance improvement
  • βœ… Test update
  • πŸ”§ Build configuration change
  • 🧹 Chore

πŸ“‹ Changes Made

  • The extract-folder function is replaced with extract-all-folders, which extracts all possible folder paths from a runbook file name, supporting nested folders (e.g., 'postgres-demo/queries/file.runbook.sql' yields both 'postgres-demo/' and 'postgres-demo/queries/').
  • The folder option generation logic in generate-runbook-options is updated to use all extracted folders, ensuring that each unique folder path is presented as a selectable option, and preventing duplicate folder entries in the options list.

πŸ§ͺ Testing

Test Configuration:

  • Browser(s): Chrome
  • OS: MacOS

Tests performed:

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed

πŸ“Έ Screenshots

image

βœ… Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@luanlorenzo luanlorenzo self-assigned this Dec 15, 2025
@sandromello
Copy link
Contributor

βœ… Build Completed with Success, Version=1195.0.0-b8b3844

@luanlorenzo luanlorenzo merged commit caeda49 into main Dec 16, 2025
20 checks passed
@luanlorenzo luanlorenzo deleted the fix/runbooks-nested-folders branch December 16, 2025 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants