Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Upgrade fastlane and remove explicit abbrev dependency#6089

Merged
TimoPtr merged 2 commits intohome-assistant:mainfrom
rmacklin:upgrade-fastlane-and-remove-explicit-abbrev-dependency
Nov 24, 2025
Merged

Upgrade fastlane and remove explicit abbrev dependency#6089
TimoPtr merged 2 commits intohome-assistant:mainfrom
rmacklin:upgrade-fastlane-and-remove-explicit-abbrev-dependency

Conversation

@rmacklin
Copy link
Contributor

Summary

This is a follow-up to #5940:

Bump to ruby 3.4.7 #5907 did break fastlane since abbrev needs to be added manually according to fastlane/fastlane#29183.

I tested locally and I was able to reproduce the issue we have on main https://github.com/home-assistant/android/actions/runs/18520711132/job/52779842472 and after the add of abbrev the issue is gone. We need to merge this PR to fully test the deployment.

A couple days ago, fastlane published a new released which supports ruby 3.4.0 without us having to manually
declare a dependency on the abbrev gem:
https://github.com/fastlane/fastlane/releases/tag/2.229.0
so this PR upgrades fastlane to that version, and removes the workaround of declaring abbrev in our own Gemfile.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines. N/A
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Of note, this version supports ruby 3.4.0 without having to manually
declare a dependency on the abbrev gem:
https://github.com/fastlane/fastlane/releases/tag/2.229.0
…#5940)"

This reverts commit f3dcd62. Now that
we are using the new version of fastlane (which declares its own
dependency on the `abbrev` gem), we don't need to declare this
dependency in our Gemfile.
Copilot AI review requested due to automatic review settings November 23, 2025 21:50
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rmacklin

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades fastlane from version 2.228.0 to 2.229.0 and removes the workaround dependency on the abbrev gem. The newer version of fastlane now properly declares abbrev as its own dependency, eliminating the need for the explicit workaround that was added in PR #5940 to fix Ruby 3.4 compatibility issues.

Key Changes

  • Upgraded fastlane from 2.228.0 to 2.229.0
  • Removed explicit abbrev gem dependency from Gemfile (now handled by fastlane itself)
  • Updated Gemfile.lock to reflect new dependency tree with additional fastlane dependencies (csv, mutex_m)

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Gemfile Removed the explicit abbrev dependency and its explanatory comment, as fastlane now includes it
Gemfile.lock Updated to reflect fastlane 2.229.0 upgrade, showing abbrev now as a transitive dependency through fastlane, and added new fastlane dependencies (csv, mutex_m)

@rmacklin rmacklin marked this pull request as ready for review November 23, 2025 21:51
@TimoPtr
Copy link
Member

TimoPtr commented Nov 24, 2025

Thanks for the change

@TimoPtr TimoPtr merged commit 4e3f1e3 into home-assistant:main Nov 24, 2025
24 checks passed
@rmacklin rmacklin deleted the upgrade-fastlane-and-remove-explicit-abbrev-dependency branch November 24, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants