Conversation
| }, | ||
| onNext = onOnboardingDone, | ||
| ) | ||
| // TODO: Consider making auth_code a value class to prevent string parameter mismatches |
There was a problem hiding this comment.
I tried it (I have a stash with the changes). I've used a value class in the AuthRepository to enforce a strong type but then this types is not properly use by the navigation library and it needs a custom NavType mapping which I don't like.
I hope this is going to work in nav3 let see, for now I'm going to keep it like this.
| if (isError) { | ||
| Text( | ||
| text = stringResource(commonR.string.manual_server_wrong_url), | ||
| // TODO probably wrong style and color/token |
There was a problem hiding this comment.
All TODOs regarding the color and sytle have been removed since the design team won't have time for us and for now it looks ok. We are going to need a more general change over the app later at least for the typographie.
1a70c20 to
c286eb1
Compare
|
Last TODOs to address are to verify the URL for the documentation and it is going to be addressed in another PR. |
|
Taking "No TODO should be left from the onboarding code base" very seriously: Missed: What about:
|
Removed in base branch
Missed it 👍🏻. I need to decide what to do here.
Missed it 👍🏻. Removed
Already removed in #6115
Removed in base branch
Missed 👍🏻. Need to be handled |
|
What was addressed seems good. I tried checking the tests and think everything moved to a logical place but might've missed one, especially back stack navigation with multiple screens is sometimes hard to place. Setting this as draft while you handle the 3 remaining cases in the previous comment. Please change to ready for review when decided and committed (edit: oh they're randomly in #6123 so that title is wrong, then just undraft when merged) :) |
|
@TimoPtr I think this one is ready and good now that you merged the other PR into this, but I'll let you handle the merging. |
6bca79f to
a6f230a
Compare
a6f230a to
7b9ebe4
Compare
Summary
This PR removes TODOs that we don't need anymore and address some of them when it makes sense.
Checklist
Any other notes
No TODO should be left from the onboarding code base the last one is going to be address in #6115
The split of the tests are in a dedicated commit that can be ignored.