Rename LauncherActivity to LaunchActivity#6169
Merged
Conversation
jpelgrom
approved these changes
Dec 18, 2025
Member
jpelgrom
left a comment
There was a problem hiding this comment.
Good thing we caught this before doing a public beta, and hard to spot during debug testing (sorry).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@dshokouhi found out that the shortcuts were removed when updating to the latest version available on main. It turns out it is due to the new onboarding being used in release. The new onboarding used a new activity named
.launcher.LauncherActivitycompare to the old one.launch.LaunchActivity, I didn't know until now that the shortcuts were relying on the fully qualified name of the default main activity used. Because of that when installing the new version it simply wiped all the dynamic shortcuts created.This PR does change the name of the new activity to match the old one.
While fixing this I also fixed an issue for the Launcher feature, since we were hardcoding the name of the alias, but I did renamed the alias without updating the name that was harcoded in the code ... To avoid issues I simply bring back the name of the alias to what it was before.
Checklist
Any other notes
I added a warning within the manifest to catch future changes.