Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Rename LauncherActivity to LaunchActivity#6169

Merged
TimoPtr merged 1 commit intomainfrom
fix/shortcut_disapear
Dec 19, 2025
Merged

Rename LauncherActivity to LaunchActivity#6169
TimoPtr merged 1 commit intomainfrom
fix/shortcut_disapear

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Dec 18, 2025

Summary

@dshokouhi found out that the shortcuts were removed when updating to the latest version available on main. It turns out it is due to the new onboarding being used in release. The new onboarding used a new activity named .launcher.LauncherActivity compare to the old one .launch.LaunchActivity, I didn't know until now that the shortcuts were relying on the fully qualified name of the default main activity used. Because of that when installing the new version it simply wiped all the dynamic shortcuts created.

This PR does change the name of the new activity to match the old one.

While fixing this I also fixed an issue for the Launcher feature, since we were hardcoding the name of the alias, but I did renamed the alias without updating the name that was harcoded in the code ... To avoid issues I simply bring back the name of the alias to what it was before.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

I added a warning within the manifest to catch future changes.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing we caught this before doing a public beta, and hard to spot during debug testing (sorry).

@TimoPtr TimoPtr merged commit b722b25 into main Dec 19, 2025
36 of 37 checks passed
@TimoPtr TimoPtr deleted the fix/shortcut_disapear branch December 19, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants