Refactor Assist audio recording to fix race condition using Channel#6211
Merged
Refactor Assist audio recording to fix race condition using Channel#6211
Conversation
Contributor
cb1be24 to
a857ff2
Compare
jpelgrom
reviewed
Dec 30, 2025
common/src/main/kotlin/io/homeassistant/companion/android/common/assist/AssistViewModelBase.kt
Outdated
Show resolved
Hide resolved
common/src/main/kotlin/io/homeassistant/companion/android/common/assist/AssistViewModelBase.kt
Outdated
Show resolved
Hide resolved
6f683b3 to
03639ea
Compare
03639ea to
791680b
Compare
jpelgrom
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the audio recording pipeline in AssistViewModelBase to fix a race condition when buffering audio data before STT is ready.
The issue was mostly seen when using a watch, but also on other low end devices. The issue was that the
queuewas nullify before all the data were fully sent. The new approach is to use a channel to store the data and make sure that we only use this to send the data. We only send the data when we reach the SST_START event.Checklist
Any other notes
Based on #6188.
Fixes #6048