Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pree
Copy link
Member

@pree pree commented Dec 27, 2021

Breaking change

Proposed change

Changed the naming of the nuki components, since the old naming was an integer which resulted in a buggy integrations card. Also changed it to HEX as it then represents the same ID printed on the Nuki Bridge.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @pschmitt, @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (nuki) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title fix(nuki): fixed naming of nuki integration Fix naming of nuki integration Dec 27, 2021
@MartinHjelmare MartinHjelmare changed the title Fix naming of nuki integration Fix unique_id of nuki config entry Dec 27, 2021
@MartinHjelmare
Copy link
Member

Thanks!

@MartinHjelmare MartinHjelmare merged commit 1af3177 into home-assistant:dev Dec 27, 2021
@MartinHjelmare
Copy link
Member

Should this go out in a patch release?

@pree
Copy link
Member Author

pree commented Dec 27, 2021

Should this go out in a patch release?

yeah, sure. Since this is just a fix.

@frenck frenck added this to the 2021.12.7 milestone Dec 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2021
@pree pree deleted the fix/nuki branch January 9, 2022 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuki integration logo missing

5 participants