Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@frenck
Copy link
Member

@frenck frenck commented Dec 29, 2021

Proposed change

The Tuya API provides functions definitions and status_ranges; These are a bit of the same and most often mixed up (which origins are already in the original Tuya V2 custom integration).

Looking at the specs, the issues reported and the upstream client code, we should use the type description from the function instead of the status range when we are using an exposed/changeable functionality.

This PR adjusts it for the light entities.

Tested against of bunch of bulbs and light I have locally, to verify those still work as expected.

replaces and closes #62985

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @tuya, @zlinoliver, @METISU, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck merged commit 12a57ad into dev Dec 29, 2021
@frenck frenck deleted the frenck-2021-3385 branch December 29, 2021 14:35
@frenck frenck mentioned this pull request Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tuya bulbs are unsupported Since 2021.11.x Tuya lights integration shown as (unsupported)

4 participants