Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@emontnemery
Copy link
Contributor

Proposed change

Correct local import of paho-mqtt

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@jbouwh
Copy link
Contributor

jbouwh commented Mar 10, 2022

Look good to me, but is there a way to test this?

@thecode
Copy link
Member

thecode commented Mar 10, 2022

I am not sure if this is related, but dev container fails to run tests unless paho-mqtt is installed, so maybe this should also be added to the requirements_test.txt if it is needed for type checking?

@emontnemery
Copy link
Contributor Author

@thecode could it be that the problem with dev container is also fixed by this PR?

@emontnemery emontnemery merged commit e5523ef into dev Mar 10, 2022
@emontnemery emontnemery deleted the mqtt_correct_paho_import branch March 10, 2022 09:32
@thecode
Copy link
Member

thecode commented Mar 10, 2022

@thecode could it be that the problem with dev container is also fixed by this PR?

Yes it does, just verified, uninstalled paho-mqtt, got an error after, rebase to dev and it is fixed, Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error occurred loading configuration flow for integration ios

7 participants