Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dgomes
Copy link
Contributor

@dgomes dgomes commented Mar 11, 2022

Proposed change

Bump media player mediaroom dependency to 0.6.5 (addressing upgrade in HA to async_timeout 4.0)

Changes in pymediaroom:
dgomes/pymediaroom@0.6.4.1...0.6.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@dgomes dgomes marked this pull request as draft March 11, 2022 23:19
@dgomes dgomes marked this pull request as ready for review March 11, 2022 23:25
@balloob balloob merged commit 380f042 into home-assistant:dev Mar 11, 2022
balloob pushed a commit that referenced this pull request Mar 11, 2022
@balloob balloob mentioned this pull request Mar 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mediaroom integration not working

4 participants