Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@edenhaus
Copy link
Member

@edenhaus edenhaus commented Nov 4, 2025

Breaking change

Proposed change

With #155447, I removed building nightlies for deprecated archs. This had the impact that wheels are no longer built for the deprecated archs. HA 2025.11 is still supporting them, and therefore, we should also build them on dev. Wheels are also built for the RC branch, but then on each patch release, we need to wait for that pipeline to finish. In addition, if a merged dependency has an issue building on deprecated archs, we would not find it out until we cut the patch release.

Wheels pipeline: https://github.com/home-assistant/core/actions/runs/19073121974

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Nov 4, 2025
@edenhaus
Copy link
Member Author

edenhaus commented Nov 4, 2025

Test failures unrelated

@edenhaus edenhaus marked this pull request as ready for review November 4, 2025 15:55
@edenhaus edenhaus requested a review from a team as a code owner November 4, 2025 15:55
Copilot AI review requested due to automatic review settings November 4, 2025 15:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds build configuration for additional CPU architectures (armhf, armv7, i386) to the build system, while explicitly excluding them from the base image build workflow.

Key changes:

  • Added base image definitions for armhf, armv7, and i386 architectures in the build configuration
  • Configured the GitHub Actions workflow to exclude these architectures from the build_base job

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
build.yaml Adds base image references for armhf, armv7, and i386 architectures
.github/workflows/builder.yml Excludes armhf, armv7, and i386 from the build_base job matrix

@edenhaus edenhaus force-pushed the edenhaus-readd-deprecated-arch-for-wheels branch from 43393c6 to 5652662 Compare November 4, 2025 18:00
@edenhaus edenhaus marked this pull request as draft November 4, 2025 18:00
@edenhaus edenhaus force-pushed the edenhaus-readd-deprecated-arch-for-wheels branch from 5652662 to 73fee44 Compare November 4, 2025 18:01
@edenhaus edenhaus marked this pull request as ready for review November 4, 2025 18:01
@edenhaus
Copy link
Member Author

edenhaus commented Nov 4, 2025

test failure unrelated

@edenhaus edenhaus merged commit fb1f258 into dev Nov 4, 2025
127 of 135 checks passed
@edenhaus edenhaus deleted the edenhaus-readd-deprecated-arch-for-wheels branch November 4, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants