Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@balloob
Copy link
Member

@balloob balloob commented Sep 19, 2019

Description:

PyTradfri didn't had a pinned version of a dependency and it's not compatible with the recently released version. This new pytradfri version fixes it.

Fix by @ggravlingen

Related issue (if applicable): fixes #26673

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.99.1 milestone Sep 19, 2019
@probot-home-assistant probot-home-assistant bot added integration: tradfri small-pr PRs with less than 30 lines. labels Sep 19, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played with this one earlier today, will address it.

@ggravlingen
Copy link
Contributor

@balloob @frenck I moved some files around in pytradfri, that's why the tests are failing. I've adressed this in https://github.com/home-assistant/home-assistant/pull/26659/files

It should be sufficient to make these changes for the tests to pass:
image

It'll be a few more days to get #26659 working so don't wait for it.

@pvizeli pvizeli merged commit 1e5de9e into dev Sep 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the bump-tradfri branch September 19, 2019 18:49
balloob added a commit that referenced this pull request Sep 19, 2019
* Bump TRADFRI

* Fix test
@balloob balloob mentioned this pull request Sep 19, 2019
@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tradfri integration breaks if updating to v0.99.0

6 participants