Merged
Conversation
* Wrap found target in list * Fix test_messages_to_targets_route
|
@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli, @robbiet480 and @molobrakos to be potential reviewers. |
Contributor
|
#3769 has been fixed. |
Contributor
|
May want to hold for #3821? |
Contributor
* Only pass through the target if it has a value * Target will no longer be none
* Restore Optional Target Config Attribute * Fix Tabs * Change indents to spaces * Make a target fix * Change to simpler not syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notify.html5_unnamed_device_2) the target was not submitted to the platform as a list causing iteration over every character in the string. (@robbiet480)Not releasing this yet as Robbie wanted to get #3769 in but it doesn't seem to be ready yet.